Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout for post to DCR fronts in dev #27660

Merged
merged 4 commits into from
Dec 11, 2024

Conversation

DanielCliftonGuardian
Copy link
Contributor

@DanielCliftonGuardian DanielCliftonGuardian commented Dec 10, 2024

What is the value of this and can you measure success?

Network fronts requests when developing locally constantly timeout due to the larger size of these fronts. They can take up to 10 seconds so I have changed the timeout in dev to allow for this.

Screenshots

Before After
before after

Checklist

@DanielCliftonGuardian DanielCliftonGuardian marked this pull request as ready for review December 10, 2024 12:33
@DanielCliftonGuardian DanielCliftonGuardian requested a review from a team as a code owner December 10, 2024 12:33
@DanielCliftonGuardian DanielCliftonGuardian changed the title Increase timeout for post to DCR Increase timeout for post to DCR fronts in dev Dec 10, 2024
Copy link
Member

@arelra arelra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@prout-bot
Copy link
Collaborator

Seen on FRONTS-PROD, ADMIN-PROD (merged by @DanielCliftonGuardian 13 minutes ago)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants