Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a 0% test for crosswords in DCR #27706

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Conversation

sndrs
Copy link
Member

@sndrs sndrs commented Jan 9, 2025

What is the value of this and can you measure success?

enable previewing of DCR crosswords

What does this change?

adds a 0% test to render crosswords in DCR

Todo

  • add a 0% test
  • render crossword article requests with DCR if the user is in the test

@sndrs sndrs marked this pull request as ready for review January 10, 2025 10:21
@sndrs sndrs requested a review from a team as a code owner January 10, 2025 10:21
@sndrs sndrs force-pushed the e2e/dcr-crosswords-ab branch from b322feb to a6b6bdb Compare January 10, 2025 10:21
@oliverabrahams oliverabrahams merged commit 85fd861 into main Jan 14, 2025
6 checks passed
@oliverabrahams oliverabrahams deleted the e2e/dcr-crosswords-ab branch January 14, 2025 10:34
@prout-bot
Copy link
Collaborator

Seen on FRONTS-PROD (created by @sndrs and merged by @oliverabrahams 12 minutes and 5 seconds ago)

@prout-bot
Copy link
Collaborator

Seen on ADMIN-PROD (created by @sndrs and merged by @oliverabrahams 12 minutes and 11 seconds ago)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants