Pull panda-hmac into repo #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-nowak
commented
Nov 20, 2023
| @@ -1 +1 @@ | |||
| version in ThisBuild := "1.4.1-SNAPSHOT" | |||
| version in ThisBuild := "3.0.0-SNAPSHOT" | |||
There was a problem hiding this comment.
big bump but IMO, panda-hmac should be on the same version numbers as the other modules, but currently panda-hmac is on 2.2.0 and the rest of panda is on 1.4.0.
This could be 2.3.0 but it seems weird to me that most panda modules would not only jump to a new major version, but not even have a x.0.0 release? maybe i'm overthinking it though
jonathonherbert
approved these changes
Nov 20, 2023
|
are you referring to hmac-headers? yeah I'm leaving that repo where it is since it's nicely independent of the rest of the panda ecosystem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@guardian/digital-cms
Pull the contents of the panda-hmac repo into this one, allowing us to release all panda-related modules simultaneously and reducing repo fragmentation.