Re-merge of PR #150: Support accepting multiple public keys #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the `acceptedPublicKeys` val is evaluated eagerly within the `Verification` trait then the `activePublicKey` and `alsoAccepted` vals won't have been initialised yet from the class which extends the trait. This was leading to `acceptedPublicKeys` evaluating to 'null' at runtime. The added test was failing with the pre-existing code with a very similar message to the one observed in CODE, so we have some confidence that it's testing for this case effectively. See: https://docs.scala-lang.org/tutorials/FAQ/initialization-order.html Co-authored-by: Roberto Tyley <52038+rtyley@users.noreply.github.com>
I'm trying to find out why `PublicSettings` in s3-uploader (guardian/s3-upload#58) didn't log that the panda settings had changed - maybe the refresh schedule did not start, or possibly the interval was no good (rounded to nothing)?
…ic-keys Support accepting multiple public keys
…her-instances' See #150 (comment) ...this merge is _actually_ merging #150 into main branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #150 (comment), the merging of PR #150 went wrong - because PR #150 was sitting on top of PR #155, and that PR had been merged to
mainonly seconds earlier at 12:50pm, when I merged PR #150 moments later, it was merged into the now-redundantfix-creation-of-superfluous-PanDomainAuthSettingsRefresher-instancesbranch of #155, rather thanmain. I didn't see this, and kicked off a release, so v6.0.0 doesn't contain #150, which I was intending it to.This new PR is purely for re-merging that branch, this time into
main- our branch rulesets means it has to be another PR!