Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Java and sbt in dependency-graph workflow #275

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

emdash-ie
Copy link
Contributor

What does this change?

The sbt-dependency-graph workflow has started failing, because it uses ubuntu-latest but doesn’t install Java or sbt: since github have updated ubuntu-latest to point to ubuntu-24.04, it has less software pre-installed by default.

The updates come from copying the version in
https://github.com/guardian/content-api-transformer-lambda/pull/95, which was raised by the bot recently and has been updated to install the necessary dependencies.

How to test

We could alter the triggers for the workflow to let it run on this branch in order to test it, but since it's working correctly on content-api-transformer-lambda already, I'm tempted to just merge and see.

The sbt-dependency-graph workflow has started failing, because it uses
ubuntu-latest but doesn’t install Java or sbt: since github have updated
ubuntu-latest to point to ubuntu-24.04, it has less software
pre-installed by default.

The updates come from copying the version in
guardian/content-api-transformer-lambda#95,
which was raised by the bot recently and has been updated to install the
necessary dependencies.
@emdash-ie emdash-ie requested a review from a team as a code owner December 12, 2024 10:08
Copy link
Member

@johnduffell johnduffell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work 👍

@johnduffell johnduffell merged commit 855aebf into main Dec 12, 2024
1 check passed
@johnduffell johnduffell deleted the fix-sbt-dependency-graph-workflow branch December 12, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants