chore: Use GitHub Actions for CI #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akash1810
force-pushed
the
aa-gha
branch
10 times, most recently
from
c158c7a to
47660ff
Compare
jacobwinch
reviewed
Sep 28, 2021
jacobwinch
reviewed
Sep 28, 2021
akash1810
commented
Sep 28, 2021
sihil
previously approved these changes
Sep 28, 2021
akash1810
force-pushed
the
aa-gha
branch
3 times, most recently
from
df05864 to
794ceb8
Compare
This allows CD to continue working.
This action should pick up the node version from the `.nvmrc` file.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Switches CI from TeamCity to GitHub Actions (with the use of https://github.com/guardian/actions-assume-aws-role).
There are a few benefits to using GHA individually:
nvmyarnCheckstab)Collectively, use of GHA means we don't have to maintain our own CI infrastructure.
How to test
devx::prismshould appear as a deployable project in Riff-Raff. It should have two files: the cloudformation and the deb and it should be successfully deployed to CODE.Have we considered potential risks?
Deployment gets a little tricky as the Riff-Raff project name has changed and we all have to remember this. Riff-Raff restrictions help here though.