-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for missing sbt by using new guardian/setup-scala
action
#24
Fix for missing sbt by using new guardian/setup-scala
action
#24
Conversation
guardian/setup-scala
action
18e3c5e
to
887e7eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! I was there while you made it though, so you may want another review.
uses: rtyley/setup-java@patch-1 | ||
with: | ||
distribution: corretto | ||
java-version: 17 # Currently Java 17 required by `s3mock-testcontainers` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question actually: CI is now using 21, as specified in .tool-versions. It looks like this is a change: is that ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh my goodness, this is a great point. So actually, it turns out this line, using Java 17 and the comment, is all a copy-n-paste from etag-caching
, which does use s3mock - but redirect resolver
doesn't use s3mock
, so we definitely want to remove this line - and as we've seen, the tests for redirect resolver
pass with Java 21!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I figured it probably worked since there were no failures, but was curious about what had happened.
See more at guardian/redirect-resolver#24 Co-authored-by: Emily Bourke <emily.bourke@guardian.co.uk>
See more at: guardian/redirect-resolver#24 Co-authored-by: Emily Bourke <emily.bourke@guardian.co.uk>
Using the new GitHub Action
guardian/setup-scala
to cope withsbt
being removed from the latest Ubuntu images we use for CI. This composite action combinessetup-java
andsetup-sbt
with good defaults for the Guardian.Version of Java used by CI now specified by
.tool-versions
fileNote that (like
gha-scala-library-release-workflow
)guardian/setup-scala
requires that projects specify their Java version with anasdf
-formatted.tool-versions
file - we didn't have to add one with this PR, as we already added it forgha-scala-library-release-workflow
with 3ec016e.