Fix for missing sbt by using new guardian/setup-scala action
#24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtyley
changed the title
guardian/setup-scala action
rtyley
force-pushed
the
fix-for-missing-sbt-by-using-new-guardian-action-setup-scala
branch
from
18e3c5e
to
887e7eb
Compare
emdash-ie
approved these changes
Oct 16, 2024
emdash-ie
reviewed
Oct 16, 2024
| uses: rtyley/setup-java@patch-1 | ||
| with: | ||
| distribution: corretto | ||
| java-version: 17 # Currently Java 17 required by `s3mock-testcontainers` |
There was a problem hiding this comment.
One question actually: CI is now using 21, as specified in .tool-versions. It looks like this is a change: is that ok?
There was a problem hiding this comment.
Oh my goodness, this is a great point. So actually, it turns out this line, using Java 17 and the comment, is all a copy-n-paste from etag-caching, which does use s3mock - but redirect resolver doesn't use s3mock, so we definitely want to remove this line - and as we've seen, the tests for redirect resolver pass with Java 21!
There was a problem hiding this comment.
Great! I figured it probably worked since there were no failures, but was curious about what had happened.
emdash-ie
deleted the
fix-for-missing-sbt-by-using-new-guardian-action-setup-scala
branch
Divs-B
added a commit
to guardian/play-secret-rotation
that referenced
this pull request
Oct 16, 2024
See more at guardian/redirect-resolver#24 Co-authored-by: Emily Bourke <emily.bourke@guardian.co.uk>
Divs-B
added a commit
to guardian/play-googleauth
that referenced
this pull request
Oct 16, 2024
See more at: guardian/redirect-resolver#24 Co-authored-by: Emily Bourke <emily.bourke@guardian.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the new GitHub Action
guardian/setup-scalato cope withsbtbeing removed from the latest Ubuntu images we use for CI. This composite action combinessetup-javaandsetup-sbtwith good defaults for the Guardian.Version of Java used by CI now specified by
.tool-versionsfileNote that (like
gha-scala-library-release-workflow)guardian/setup-scalarequires that projects specify their Java version with anasdf-formatted.tool-versionsfile - we didn't have to add one with this PR, as we already added it forgha-scala-library-release-workflowwith 3ec016e.