Upgrade to Panda v5 #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtyley
force-pushed
the
upgrade-to-panda-v5
branch
from
947bbf5
to
21a9ed9
Compare
rtyley
force-pushed
the
upgrade-to-panda-v5
branch
from
21a9ed9
to
6a19c90
Compare
rtyley
commented
Aug 9, 2024
Comment on lines
-5
to
+9
| import com.gu.pandomainauth.{PanDomain, PublicKey, PublicSettings} | ||
| import com.gu.pandomainauth.{PanDomain, PublicSettings} | ||
| import play.api.Logging | ||
| import play.api.mvc._ | ||
|
|
||
| import java.security.PublicKey |
There was a problem hiding this comment.
These are the only code changes in this PR, to cope with Panda v5 and guardian/pan-domain-authentication#147.
davidfurey
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading to Panda v5.0.0 is pretty minor change, but does require a change to the imports for
PublicKey, due to PR guardian/pan-domain-authentication#147 and guardian/pan-domain-authentication#153.I've also bumped the Scala & sbt versions a tiny bit, added a gitignore line, tiny things!
Testing
This has been successfully deployed to https://s3-uploader.code.dev-gutools.co.uk/, and I've verified that it still works:
Screen.Recording.2024-08-09.at.17.20.00.mov