Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Panda v5 #59

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Upgrade to Panda v5 #59

merged 1 commit into from
Aug 9, 2024

Conversation

rtyley
Copy link
Member

@rtyley rtyley commented Aug 9, 2024

Upgrading to Panda v5.0.0 is pretty minor change, but does require a change to the imports for PublicKey, due to PR guardian/pan-domain-authentication#147 and guardian/pan-domain-authentication#153.

I've also bumped the Scala & sbt versions a tiny bit, added a gitignore line, tiny things!

Testing

This has been successfully deployed to https://s3-uploader.code.dev-gutools.co.uk/, and I've verified that it still works:

Screen.Recording.2024-08-09.at.17.20.00.mov

@rtyley rtyley changed the title Upgrade to panda v5 Upgrade to Panda v5 Aug 9, 2024
Comment on lines -5 to +9
import com.gu.pandomainauth.{PanDomain, PublicKey, PublicSettings}
import com.gu.pandomainauth.{PanDomain, PublicSettings}
import play.api.Logging
import play.api.mvc._

import java.security.PublicKey
Copy link
Member Author

@rtyley rtyley Aug 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the only code changes in this PR, to cope with Panda v5 and guardian/pan-domain-authentication#147.

@rtyley rtyley marked this pull request as ready for review August 9, 2024 16:15
@rtyley rtyley requested a review from davidfurey August 9, 2024 16:22
Copy link
Member

@davidfurey davidfurey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the video, makes for speedy PR review

@rtyley rtyley merged commit 0a80001 into main Aug 9, 2024
3 checks passed
@rtyley rtyley deleted the upgrade-to-panda-v5 branch August 9, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants