Skip to content
This repository has been archived by the owner on Dec 6, 2022. It is now read-only.

get-icons #1 - Move icon components to components folder #1304

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

SiAdcock
Copy link
Contributor

What is the purpose of this change?

Paving the way to populating icons from Figma.

The icons root folder is likely to become larger and more cluttered:

  • more icons components will be added
  • svgs will be added
  • 2 different icon sizes will be available

We should add more structure to the icons folder to accommodate this. We'll do this pre-emptively, to keep subsequent PRs small.

What does this change?

  • Move icon components into a components folder under the icons root

@SiAdcock SiAdcock requested a review from a team as a code owner March 14, 2022 14:53
@changeset-bot
Copy link

changeset-bot bot commented Mar 14, 2022

⚠️ No Changeset found

Latest commit: 97a2c3c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the react-components Affects @guardian/source-react-components label Mar 14, 2022
@SiAdcock SiAdcock mentioned this pull request Mar 14, 2022
10 tasks
@SiAdcock SiAdcock changed the title Move icon components to components folder get-icons #1 - Move icon components to components folder Mar 15, 2022
@SiAdcock SiAdcock merged commit 2dfa40a into main Mar 15, 2022
@SiAdcock SiAdcock deleted the sa-icon-components-folder branch March 15, 2022 14:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
react-components Affects @guardian/source-react-components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant