Scala 2.13 upgrade #195
Scala 2.13 upgrade #195
Conversation
| "com.gu" %% "thrift-serializer" % "4.0.0", | ||
| "com.gu" %% "thrift-serializer" % "4.0.2", |
There was a problem hiding this comment.
This was the first version of thrift-serializer to support Scala 2.13, so this is the most minimal change I could make to get the project to compile. There have been many newer versions since then, the current is 5.0.7:
https://index.scala-lang.org/guardian/thrift-serializer/artifacts/thrift-serializer
Switched from `JavaConverters` to 2.13's `CollectionConverters`. Widening conversion from `Long` to `Double` is deprecated, so used `toDouble` instead. Previously `Buffer` could be assigned to `Seq`, because `Seq` was mutable. Now `Seq` is immutable by default, so `toSeq` is needed to create a `Seq` from a `Buffer`. `Either` is now right-biased, so `.right` is no longer needed. `.mapValues` is deprecated, need `.view.mapValues` instead. `.toMap` is also needed to get back to a `Map` from a `MapView`. Auto-application is deprecated, so `()` must be added in some cases. Deleted `Enumerators` because it wasn't used, and it was using features unsupported in Scala 2.13.
JamieB-gu
force-pushed
the
upgrade-to-scala-v2.13
branch
from
17e8f52
to
a5bd3f6
Compare
|
The snyk project for this application is called |
As you predicted, once merged, there was a new story-packages:story-packages_2.13 snyk project, effectively a duplicate:
...so I have now deleted the old story-packages:story-packages_2.12 one:
|
|
I've double-checked https://packages.gutools.co.uk/editorial, and it looks good! |
Required for
facia-scala-clientto drop support for Scala 2.12: guardian/facia-scala-client#317Scala 2.13 Fixes
JavaConvertersto 2.13'sCollectionConverters.LongtoDoubleis deprecated, so usedtoDoubleinstead.Buffercould be assigned toSeq, becauseSeqwas mutable. NowSeqis immutable by default, sotoSeqis needed to create aSeqfrom aBuffer.Eitheris now right-biased, so.rightis no longer needed..mapValuesis deprecated, need.view.mapValuesinstead..toMapis also needed to get back to aMapfrom aMapView.()must be added in some cases.Enumeratorsbecause it wasn't used, and it was using features unsupported in Scala 2.13.Testing In CODE
We deployed to CODE and created a new package, as seen here:
See also