Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Java 11 #200

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Upgrade to Java 11 #200

merged 3 commits into from
Oct 29, 2024

Conversation

davidfurey
Copy link
Member

@davidfurey davidfurey commented Oct 25, 2024

What does this change?

Upgrading to Java 11 in preparation for upgrading to Play 3

  • Use Java 11 in CI
  • Switch Debian package dependency to Java 11
  • Switch to Java 11 AMI

How to test

Deploy to CODE, check that application still runs at the articles can be added to a story package

@davidfurey davidfurey requested a review from a team as a code owner October 25, 2024 09:33
Copy link
Member

@rtyley rtyley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, nice one! This satisfies one of the updated requirements of Panda v7 - as of guardian/pan-domain-authentication#150 it requires Java 11.

java-version: '8'
java-version: '11'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! Note you could also use guardian/setup-scala, like this - which would reduce config a bit, ensure that sbt is always present, and upgrade this workflow to setup-java@v4.

@rtyley
Copy link
Member

rtyley commented Oct 25, 2024

Note you could also use guardian/setup-scala

...oh, I've just noticed that this project already has a .tool-versions file (as of #196) and so at minimum, if you're upgrading this project to Java 11, you'd want to update the version in the .tool-versions file as it currently says:

java corretto-8.422.05.1

...you'd want it to say:

java corretto-11.0.25.9.1

...then, if you switched to guardian/setup-scala, you'd be able to remove the Jva version from ci.yml altogether, as guardian/setup-scala would read it from the .tool-versions file.

@davidfurey
Copy link
Member Author

Tested in CODE

Comment on lines -23 to -27
"-J-XX:MaxRAMFraction=2",
"-J-XX:InitialRAMFraction=2",
"-J-XX:MaxMetaspaceSize=500m",
"-J-XX:+PrintGCDetails",
"-J-XX:+PrintGCDateStamps",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! I need to add this to the checklist at guardian/maintaining-scala-projects#3

@davidfurey davidfurey merged commit 50104b3 into main Oct 29, 2024
3 checks passed
@prout-bot
Copy link

Seen on PROD (merged by @davidfurey 7 minutes and 25 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants