Upgrade to Java 11 #200
Upgrade to Java 11 #200
Conversation
There was a problem hiding this comment.
Looks great, nice one! This satisfies one of the updated requirements of Panda v7 - as of guardian/pan-domain-authentication#150 it requires Java 11.
| java-version: '8' | ||
| java-version: '11' |
There was a problem hiding this comment.
Good stuff! Note you could also use guardian/setup-scala, like this - which would reduce config a bit, ensure that sbt is always present, and upgrade this workflow to setup-java@v4.
...oh, I've just noticed that this project already has a Line 1 in fe2029c ...you'd want it to say: ...then, if you switched to |
As part for Java 8 -> Java 11 upgrade
|
Tested in CODE |
| "-J-XX:MaxRAMFraction=2", | ||
| "-J-XX:InitialRAMFraction=2", | ||
| "-J-XX:MaxMetaspaceSize=500m", | ||
| "-J-XX:+PrintGCDetails", | ||
| "-J-XX:+PrintGCDateStamps", |
There was a problem hiding this comment.
Great stuff! I need to add this to the checklist at guardian/maintaining-scala-projects#3
|
Seen on PROD (merged by @davidfurey 7 minutes and 25 seconds ago) Please check your changes! |
What does this change?
Upgrading to Java 11 in preparation for upgrading to Play 3
How to test
Deploy to CODE, check that application still runs at the articles can be added to a story package