Play 3.0 upgrade #201
Play 3.0 upgrade #201
Conversation
There was a problem hiding this comment.
Looks good! ✨
One exciting thing to watch out for with upgrades to Play 3, as noted in guardian/maintaining-scala-projects#4, is that as the Maven group id of Playframework has changed (com.typesafe.play → org.playframework), there's the potential for scary runtime errors if, for instance, both old and new versions of the play-json library are imported - sbt won't detect the collision, as the artifacts will have different group ids.
Thanks, I've fixed that now |
Requires FAPI and pan-domain-auth-play upgrades to versions with support for Play, and then content-api-client-aws and capi-models upgrades for versions alignment. Jackson version is bumped by Play, but still needs override due to jackson-module-scala brought in by Pekko
Also resolves deprecation warning
Co-authored-by: Roberto Tyley <52038+rtyley@users.noreply.github.com>
davidfurey
force-pushed
the
play-3.0-upgrade
branch
from
a29ff21
to
6ab465e
Compare
|
Seen on PROD (merged by @davidfurey 6 minutes and 23 seconds ago) Please check your changes! |
What does this change?
Minimal changes to get to Play 3.0
Requires FAPI and pan-domain-auth-play upgrades to versions with support for Play.
This then required content-api-client-aws and capi-models to be upgraded to align versions of common dependencies.
There still seems to be a Jackson incompatibility between Play and Pekko.