Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play 3.0 upgrade #201

Merged
merged 4 commits into from
Oct 29, 2024
Merged

Play 3.0 upgrade #201

merged 4 commits into from
Oct 29, 2024

Conversation

davidfurey
Copy link
Member

What does this change?

Minimal changes to get to Play 3.0

Requires FAPI and pan-domain-auth-play upgrades to versions with support for Play.

This then required content-api-client-aws and capi-models to be upgraded to align versions of common dependencies.

There still seems to be a Jackson incompatibility between Play and Pekko.

@davidfurey davidfurey requested a review from a team as a code owner October 25, 2024 15:26
Copy link
Member

@rtyley rtyley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! ✨

One exciting thing to watch out for with upgrades to Play 3, as noted in guardian/maintaining-scala-projects#4, is that as the Maven group id of Playframework has changed (com.typesafe.playorg.playframework), there's the potential for scary runtime errors if, for instance, both old and new versions of the play-json library are imported - sbt won't detect the collision, as the artifacts will have different group ids.

project/build.properties Outdated Show resolved Hide resolved
@davidfurey
Copy link
Member Author

Looks good! ✨

One exciting thing to watch out for with upgrades to Play 3, as noted in guardian/maintaining-scala-projects#4, is that as the Maven group id of Playframework has changed (com.typesafe.playorg.playframework), there's the potential for scary runtime errors if, for instance, both old and new versions of the play-json library are imported - sbt won't detect the collision, as the artifacts will have different group ids.

Thanks, I've fixed that now

davidfurey and others added 4 commits October 29, 2024 14:59
Requires FAPI and pan-domain-auth-play upgrades to versions with support for Play, and then content-api-client-aws and capi-models upgrades for versions alignment.

Jackson version is bumped by Play, but still needs override due to jackson-module-scala brought in by Pekko
Co-authored-by: Roberto Tyley <52038+rtyley@users.noreply.github.com>
@davidfurey davidfurey changed the base branch from java-11-upgrade to main October 29, 2024 16:06
@davidfurey davidfurey merged commit 07fa724 into main Oct 29, 2024
1 check passed
@prout-bot
Copy link

Seen on PROD (merged by @davidfurey 6 minutes and 23 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants