Support previewing a design directly #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjmw
force-pushed
the
tw/preview-design
branch
from
d547a3a to
f88b8c4
Compare
No support for showing a ticker yet.
tjmw
force-pushed
the
tw/preview-design
branch
from
f88b8c4 to
b9d02c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds live previewing to the banner design page, using a hardcoded variant configuration. In a future PR I'd like to add limited configuration of the variant (toggling the ticker for example) but for now I think this is a good first step.
How to test
Run locally or on CODE. Click that live preview button!
How can we measure success?
Have we considered potential risks?
Images
Accessibility