Add article count copy editor field #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomrf1
reviewed
Jan 23, 2024
| import { useForm } from 'react-hook-form'; | ||
|
|
||
| interface FormData { | ||
| copy: string; |
There was a problem hiding this comment.
If you clear the contents of this field does the tool submit an empty string (rather than null) to the database? I'm wondering what then happens in the epic
There was a problem hiding this comment.
good question, yes it does. But the epic logic checks that it contains "%%ARTICLE_COUNT%%" anyway, though arguably we shouldn't rely on this.
There was a problem hiding this comment.
That makes sense. Perhaps it's worth being defensive and transforming '' to undefined in this component?
| @@ -18,6 +24,20 @@ const VariantEditorSeparateArticleCountEditor: React.FC<VariantEditorSeparateArt | |||
| updateSeparateArticleCount(Boolean(separateArticleCount) ? undefined : { type: 'above' }); | |||
There was a problem hiding this comment.
the way this worked before means that the copy will be lost if "Above" is set to false, which I guess is fine?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds the "copy" property to Epic test models (already exists here) and creates an editor field for it.
How to test
Edit a variant of an epic test - update the "Article count copy" under "Separate article count". Preview and see this copy. Save, reload and see the copy is still there.
How can we measure success?
Have we considered potential risks?
Images
Accessibility