Create apple news epic choice cards editor #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Create a custom editor for the apple news epic choice cards / primary button. This will enable toggling between "choice cards" (ie 3 buttons) and 1 primary button in epics.
Doing this in the tooling allows RRCP users to toggle this instead of developers hardcoding it. See trello ticket for background on why we want this changed and https://github.com/guardian/apple-news/pull/307 for the change in the apple news epics to support this.
How to test
Create new apple news epic - "show choice cards" radio button should be toggled by default. Toggle to "Enable primary button" and default config should be set. Save and reload to see config saved correctly. Test in Apple news...
How can we measure success?
Have we considered potential risks?
Images
Accessibility