Banner test deploySchedule #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shtukas
approved these changes
Oct 14, 2024
|
Just based on the screenshot above, is it clear what the number means to the users? |
good spot - that was the wrong screenshot! I've just updated it |
charleycampbell
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated SDC change: guardian/support-dotcom-components#1235
Marketing want the ability to override the channel-wide deploy schedule.
For example: channel 2 deploys weekly, but they'd like to show an app install banner (for mobile users) every 24 hours.
The solution implemented here is to add a
deployScheduleto theBannerTestmodel, to allow Marketing users to override the channel-wide deploy schedule. When set, it allows them to set the number of days between deploys per user. This uses the user'slastClosedAttimestamp to decide when to next deploy the banner.