Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Country wide targetting #674

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Conversation

LAKSHMIRPILLAI
Copy link
Contributor

@LAKSHMIRPILLAI LAKSHMIRPILLAI commented Jan 22, 2025

Co-authored with: @charleycampbell

What does this change?

Country wide targeting in RRCP

Trello card

This PR is to enable country wide targeting along with Region wide targeting in RRCP under the 'Target Audience' section .The countries to be targeted can be selected from the dropdown list .The supporting changes in support-dotcom-component are in the SDC PR

How to test

Test in CODE

  1. Deploy the SAC and SDC branches for the country wide targeting in CODE
  2. Create a test/Modify an existing test to add a country to target from the dropdown and set it to Live
  3. Open the code url https://m.code.dev-theguardian.com in the Chrome and using the bookmark change the geolocation - Instructions to change GeoLocation here ->http://reader-revenue-bookmarklets.s3-website-eu-west-1.amazonaws.com/
  4. The Epic should shown for those geolocation that the test is targeting

Images

image

@LAKSHMIRPILLAI LAKSHMIRPILLAI force-pushed the lp-add-target-by-country branch from 1a10039 to e736633 Compare January 22, 2025 12:13
@LAKSHMIRPILLAI LAKSHMIRPILLAI marked this pull request as ready for review January 27, 2025 12:45
@LAKSHMIRPILLAI LAKSHMIRPILLAI requested a review from a team as a code owner January 27, 2025 12:45
@LAKSHMIRPILLAI LAKSHMIRPILLAI marked this pull request as draft January 28, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant