Bugfix for webpack-dev-server 3.1.11 #1795
Conversation
…roduced changes that cause constant console logging running locally
| @@ -11,7 +11,7 @@ | |||
| "build-ssr": "webpack --config webpack.ssr.js && node scripts/ssrScript.js", | |||
| "build-prod": "npm-run-all clean validate test storybook-static 'webpack --config webpack.prod.js --env.prod'", | |||
| "webpack": "webpack", | |||
| "webpack-dev-server": "webpack-dev-server --config webpack.dev.js --port 9211 --public support.thegulocal.com", | |||
| "webpack-dev-server": "webpack-dev-server --config webpack.dev.js --port 9211 --public support.thegulocal.com --disable-host-check", | |||
There was a problem hiding this comment.
is it possible to add a comment with a link to the issue jonny was looking at?
There was a problem hiding this comment.
@johnduffell comments are not supported in json files so we settled for a PR with the documentation 😢
|
good, but see my comment. although it can be linked back to the PR, it might be nice to comment inline so it is more obvious. |
|
@johnduffell your PR was definitely not the source of the issue - you just brought the Also, unfortunately inline comments are not supported in |
|
Related PR: #1774 |
|
✅ Testing in PROD passed! Details |
prout-bot
added
Pass-in-PROD
Seen-on-PROD
and removed
Pass-in-PROD
Pending-on-PROD
labels
|
Seen on PROD (merged by @jlieb10 13 minutes ago)
Sentry Release: support-client-side, support |
|
✅ Testing in PROD passed! Details |
Upgrading webpack-dev-server to 3.1.11 causes constant console logging due to new security features. The current best supported work around is to add the
--disable-host-checkflag to thescript in
package.jsonPlease see webpack-dev-server's documentation of this issue here
TBD: check to see if this flag is still necessary next time we upgrade webpack-dev-server