Press reader entitlements API #2513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploy build 9593 of
|
Deploy build 9593 of
|
Deploy build 9593 of
|
Deploy build 9360 of
|
- fix valid products array type
rupertbates
force-pushed
the
press-reader-entitlements
branch
from
5a05381 to
cd070df
Compare
| import { getIdentityIdSchema } from './schemas'; | ||
|
|
||
| export async function getIdentityClientAccessToken() { | ||
| const ssmClient = new SSMClient(awsConfig); |
There was a problem hiding this comment.
Should we put this outside the function, the same way we're doing with the dynamoClient?
There was a problem hiding this comment.
I've put the fetching of the client access token into a Lazy value so that it will only be fetched once
There was a problem hiding this comment.
Nice! That's very cool. Should we do the same for loading the product catalog?
andrewHEguardian
changed the title
rupertbates
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Create a new API gateway + lambda to serve user entitlements to Press Reader app. We accept a user ID, which we will swap for an identity ID and query supporter product data to work out whether someone is entitled to use the app. The response is an XML doc.
Trello card
How to test
Make a request to https://press-reader-entitlements-code.support.guardianapis.com/user-entitlements with a user ID query param and the api key as a header.