Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing gha-scala-release-process in this library. #27

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

Divs-B
Copy link
Contributor

@Divs-B Divs-B commented Jan 17, 2024

What does this change?

Simplify and automise the release process on Copip libraries by implementing gha-scala-library-release-workflow that is more secured, quicker, easy to deploy and removes boilerplate code from build.sbt, release.yml as well.

We granted secerts access to this repo via adding the repo name in github-secret-access
https://github.com/guardian/github-secret-access/pull/36

steps mentioned in Configuration has been followed.
https://github.com/guardian/gha-scala-library-release-workflow/blob/main/docs/configuration.md

How to test

By making release once the PR is reviewed and merged.

How can we measure success?

Released version and details should be available to be used by clients.

@Divs-B Divs-B requested a review from rtyley January 17, 2024 13:17
@rtyley
Copy link
Member

rtyley commented Jan 17, 2024

HI @Divs-B ! A lot of this looks good, but one thing that is currently missing from this project is CI - nothing is running the tests!

Could you do a separate PR first to introduce CI on this repo, so we can see more easily if we're breaking anything? The CI should probably be setup like we did with content-api-client-aws:

Divs-B added a commit that referenced this pull request Jan 18, 2024
needed during implementation of gha-scala release process: #27 (comment)
@Divs-B Divs-B mentioned this pull request Jan 18, 2024
@Divs-B Divs-B force-pushed the db/implement-new-gha-scala-rel-process branch from 28b97a3 to a2a33c1 Compare January 18, 2024 14:38
Copy link

github-actions bot commented Jan 18, 2024

Test Results

 4 files  ±0   4 suites  ±0   0s ⏱️ ±0s
11 tests ±0  11 ✅ ±0  0 💤 ±0  0 ❌ ±0 
22 runs  ±0  22 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 6751844. ± Comparison against base commit b2f56f4.

♻️ This comment has been updated with latest results.

@Divs-B Divs-B marked this pull request as ready for review January 18, 2024 14:47
Copy link
Member

@rtyley rtyley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

It looks like https://github.com/guardian/facebook-newstab would be a good project to check that thrift-serializer functionality was still working, as it has https://github.com/guardian/facebook-newstab/blob/389db27a205f6888236d8e726da3cd056838e1ed/src/test/scala/com/gu/facebook/ContentDecachedEventSerializerSpec.scala, which at least partially exercises some of the functionality of the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants