Upgrade typerighter cdk dependencies #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PRIVATE_WITH_NAT is deprecated. Note that PRIVATE_WITH_EGRESS defaults to the same behaviour as PRIVATE_WITH_NAT, but has the option to set natGateways to 0. If we are confident that our subnet will never need to make requests to the internet, we can opt to use PRIVATE_ISOLATED instead.
Fweddi
force-pushed
the
fp/typerighter-cdk-updates
branch
from
1511957 to
f3f672b
Compare
davidfurey
approved these changes
Jul 12, 2024
Quite right, I hadn't noticed! Even more confidence 😄 |
prout-bot
added
Pending-on-Checker
Pending-on-Rule Manager
Seen-on-Rule Manager
and removed
Pending-on-Rule Manager
labels
|
Seen on Rule Manager (merged by @Fweddi 10 minutes and 3 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This upgrades typerighter's cdk dependencies, and should resolve some vulnerabilities from older libraries.
How to test
CDK tests should pass and synth successfully.
Deploy to CODE. The generated Cloudformation template should successfully update the rule database to use a 'PRIVATE_WITH_EGRESS' subnet.
The database should work the same as before - test by searching some rules on https://manager.typerighter.code.dev-gutools.co.uk.
We should also be able to connect to the database locally.
Tests complete