obscuracam 2017! #114
Merged
obscuracam 2017! #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wait - you're removing ALL face detection? |
|
We are using the more reliable local Android open-source FaceDetection, which is built into the OS, vs using it in combination with the closed source Google Play cloud-enhanced face detection, which hasn't proven to be better, and often worse. |
|
(In the long run, I want to integrate OpenCV face detect libraries opencv.org |
|
ah - apologies - groovy |
- something isn't working with the libJpegRedaction library, we'll just use inmemory bitmaps for now - also improved the flow a bit for image viewing and processing
- removed our own ffmpeg impl, in favor of: http://writingminds.github.io/ffmpeg-android-java/ - cleaned up menus and "open" at end - moved to drawbox redacting for now, instead of custom redact filter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few small error handling fixes, removal of the Google Play Vision FaceDetect (which doesn't work that well it turns out), and an update of the ffmpeg binary