Skip to content

Commit

Permalink
Agent: Forcefully kill the LDAP server process if necessary
Browse files Browse the repository at this point in the history
Using Twisted for the Log4Shell exploiter has been nothing but trouble
since the beginning. When we refactor this exploiter we should use
another solution. In the meanwhile, we must be doing something wrong WRT
stopping Twisted. The heavy-handed approach is to SIGKILL the process.
This isn't ideal, but will be changed when we refactor this component.

Issue #2820
  • Loading branch information
mssalvatore committed Jan 13, 2023
1 parent a576006 commit afed595
Showing 1 changed file with 2 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -210,5 +210,7 @@ def stop(self, timeout: Optional[float] = None):

if self._server_process.is_alive():
logger.warning("Timed out while waiting for the LDAP exploit server to stop")
logger.warning("Forcefully killing the LDAP server process")
self._server_process.kill()
else:
logger.debug("Successfully stopped the LDAP exploit server")

0 comments on commit afed595

Please sign in to comment.