Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide passwords and other credentials in UI #1183

Closed
2 of 3 tasks
VakarisZ opened this issue May 20, 2021 · 0 comments · Fixed by #1417
Closed
2 of 3 tasks

Hide passwords and other credentials in UI #1183

VakarisZ opened this issue May 20, 2021 · 0 comments · Fixed by #1417
Labels
Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island. Complexity: Low Impact: Medium sp/2

Comments

@VakarisZ
Copy link
Contributor

VakarisZ commented May 20, 2021 •
edited by mssalvatore
Loading

Describe the bug

Credential inputs in the configuration are shown plain-text.

Tasks

  • Create a component that would hide input by default, but would have an option to show plaintext on click (0.5d) @ilija-lazoroski
  • Convert all of the sensitive inputs to use this component (0.25d) @ilija-lazoroski
  • Review and address comments (0.5d) @ilija-lazoroski
@VakarisZ VakarisZ added the Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island. label May 20, 2021
@ilija-lazoroski ilija-lazoroski mentioned this issue Aug 18, 2021
Merged
7 tasks
mssalvatore added a commit that referenced this issue Aug 20, 2021
@mssalvatore
Update changelog with entry for #1183
0fc9631
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island. Complexity: Low Impact: Medium sp/2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hide input component guardicore/monkey
2 participants
@mssalvatore @VakarisZ