Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ransomware Encryption Performance #2123

Closed
mssalvatore opened this issue Jul 26, 2022 · 0 comments · Fixed by #2204
Closed

Ransomware Encryption Performance #2123

mssalvatore opened this issue Jul 26, 2022 · 0 comments · Fixed by #2204
Labels
Complexity: Low Impact: Medium Refactor

Comments

@mssalvatore
Copy link
Collaborator

Refactor

Component(s) to be refactored

  • infection_monkey.utils.bit_manipulators.py

Explanation

There are two TODOs in bit_manipulators.py relating to the perfomance of ransomware's "encryption" algorithm. Resolve these TODOs and show before and after performance benchmarks.
@cakekoa cakekoa mentioned this issue Aug 17, 2022
Merged
8 tasks
cakekoa added a commit that referenced this issue Aug 17, 2022
@cakekoa
Agent: Improve the speed of bit flipping code
51ce19b 
- Remove a function call
- Use a generator
- Use a more efficient flip calculation (subtraction instead of xor)

Issue #2123
mssalvatore pushed a commit that referenced this issue Aug 17, 2022
@cakekoa @mssalvatore
Agent: Improve the speed of bit flipping code
639fb26 
- Remove a function call
- Use a generator
- Use a more efficient flip calculation (subtraction instead of xor)

Issue #2123
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Complexity: Low Impact: Medium Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

2123: Improve the speed of bit flipping code guardicore/monkey
1 participant
@mssalvatore