Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter events by timestamp #3397

Closed
1 of 3 tasks
mssalvatore opened this issue Jun 1, 2023 · 0 comments · Fixed by #3480
Closed
1 of 3 tasks

Filter events by timestamp #3397

mssalvatore opened this issue Jun 1, 2023 · 0 comments · Fixed by #3480
Labels
Complexity: Low Feature Issue that describes a new feature to be implemented. Impact: Medium sp/5
Milestone
v2.3.0

Comments

@mssalvatore
Copy link
Collaborator

mssalvatore commented Jun 1, 2023 •
edited by shreyamalviya
Loading

Description

Add the ability to filter events by timestamp. Queries should look like:
"/api/agent-events?timestamp=gt:1685640405"

Implement the following operators:

  • gt
  • lt

Note

The current filtering approach is a simple solution that covers many, but not all use cases. Consider switching to GraphQL for advanced searching instead of using one of many poorly-defined "REST" approaches.

Tasks

  • Modify the IAgentEventRepository to guaranteed events are returned in order of timestamp ascending (0.5d) - @shreyamalviya
    • Modify the MongoAgentEventRepository to fulfill the new guarantee.
  • Add the capability to filter events by timestamp (use python's bisect()) (0.5d) - @shreyamalviya
@mssalvatore mssalvatore added Feature Issue that describes a new feature to be implemented. Impact: Medium Complexity: Low labels Jun 1, 2023
@mssalvatore mssalvatore added this to the v2.3.0 milestone Jun 1, 2023
@shreyamalviya shreyamalviya mentioned this issue Jul 10, 2023
Merged
10 tasks
mssalvatore added a commit that referenced this issue Jul 10, 2023
@mssalvatore
Merge branch '3397-events-ascending-timestamp' into develop
6d59893 
Issue #3397
PR #3479
@shreyamalviya shreyamalviya mentioned this issue Jul 10, 2023
Merged
10 tasks
mssalvatore added a commit that referenced this issue Jul 10, 2023
@mssalvatore
Merge branch '3397-filter-events-by-timestamp' into develop
fa672f0 
Issue #3397
PR #3480
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Complexity: Low Feature Issue that describes a new feature to be implemented. Impact: Medium sp/5
Projects
None yet
Milestone
v2.3.0
Development

Successfully merging a pull request may close this issue.

Filter events by timestamp in AgentEvents resource guardicore/monkey
1 participant
@mssalvatore