Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ransomware report tab #1291

Merged
merged 5 commits into from
Jul 6, 2021
Merged

Add ransomware report tab #1291

merged 5 commits into from
Jul 6, 2021

Conversation

shreyamalviya
Copy link
Contributor

@shreyamalviya shreyamalviya commented Jul 2, 2021

What does this PR do?

Fixes #1240
Ransomware tab is not hidden if no ransomware options are enabled

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

image

@ghost
Copy link

ghost commented Jul 2, 2021

Congratulations 🎉. DeepCode analyzed your code in 9.84 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

👉 The DeepCode service and API will be deprecated in August, 2021. Here is the information how to migrate. Thank you for using DeepCode 🙏 ❤️ !

If you are using our plugins, you might be interested in their successors: Snyk's JetBrains plugin and Snyk's VS Code plugin.

@codecov
Copy link

codecov bot commented Jul 2, 2021

Codecov Report

Merging #1291 (6622fc0) into develop (f698c88) will decrease coverage by 1.33%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1291      +/-   ##
===========================================
- Coverage    30.68%   29.34%   -1.34%     
===========================================
  Files          449      452       +3     
  Lines        13470    14286     +816     
===========================================
+ Hits          4133     4192      +59     
- Misses        9337    10094     +757     
Impacted Files Coverage Δ
monkey/infection_monkey/exploit/tools/helpers.py 32.00% <0.00%> (-4.37%) ⬇️
monkey/infection_monkey/exploit/wmiexec.py 23.63% <0.00%> (-3.77%) ⬇️
monkey/monkey_island/cc/app.py 0.00% <0.00%> (ø)
monkey/infection_monkey/dropper.py 0.00% <0.00%> (ø)
monkey/monkey_island/cc/server_setup.py 0.00% <0.00%> (ø)
monkey/infection_monkey/exploit/hadoop.py 0.00% <0.00%> (ø)
monkey/infection_monkey/exploit/vsftpd.py 0.00% <0.00%> (ø)
monkey/infection_monkey/model/__init__.py 100.00% <0.00%> (ø)
monkey/infection_monkey/exploit/smbexec.py 0.00% <0.00%> (ø)
monkey/infection_monkey/exploit/sshexec.py 0.00% <0.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f698c88...6622fc0. Read the comment docs.

@shreyamalviya shreyamalviya marked this pull request as ready for review July 5, 2021 09:44
Comment on lines +64 to +70
// this.authFetch('/api/report/ransomware')
// .then(res => res.json())
// .then(res => {
// this.setState({
// ransomwareReport: res
// });
// });
Copy link
Collaborator

@mssalvatore mssalvatore Jul 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This assumes that Monkey Island will instruct the frontend whether or not it should show the report, which isn't the Island's responsibility. See #1297 (comment)

This component will probably need to show the tab if there is any data in the report, or hide it otherwise.

@mssalvatore
Copy link
Collaborator

It's probably worth investigating the findings from DeepCode and addressing them.

@shreyamalviya shreyamalviya requested a review from mssalvatore July 6, 2021 10:54
@shreyamalviya shreyamalviya merged commit 999399a into develop Jul 6, 2021
@mssalvatore mssalvatore deleted the ransomware-reporting-tab branch July 29, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Basic ransomware reporting
3 participants