-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ransomware report tab #1291
Conversation
👉 View analysis in DeepCode’s Dashboard | Configure the bot👉 The DeepCode service and API will be deprecated in August, 2021. Here is the information how to migrate. Thank you for using DeepCode 🙏 ❤️ !If you are using our plugins, you might be interested in their successors: Snyk's JetBrains plugin and Snyk's VS Code plugin. |
Codecov Report
@@ Coverage Diff @@
## develop #1291 +/- ##
===========================================
- Coverage 30.68% 29.34% -1.34%
===========================================
Files 449 452 +3
Lines 13470 14286 +816
===========================================
+ Hits 4133 4192 +59
- Misses 9337 10094 +757
Continue to review full report at Codecov.
|
…lemetry is `true`
// this.authFetch('/api/report/ransomware') | ||
// .then(res => res.json()) | ||
// .then(res => { | ||
// this.setState({ | ||
// ransomwareReport: res | ||
// }); | ||
// }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This assumes that Monkey Island will instruct the frontend whether or not it should show the report, which isn't the Island's responsibility. See #1297 (comment)
This component will probably need to show the tab if there is any data in the report, or hide it otherwise.
It's probably worth investigating the findings from DeepCode and addressing them. |
What does this PR do?
Fixes #1240
Ransomware tab is not hidden if no ransomware options are enabledPR Checklist
Testing Checklist