Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ransomware quickstart - Remove "Congrats" message and change header #1314

Merged
merged 4 commits into from
Jul 13, 2021

Conversation

ilija-lazoroski
Copy link
Contributor

@ilija-lazoroski ilija-lazoroski commented Jul 12, 2021

What does this PR do?

Fixes "Remove" task from #1241

image

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

Explain Changes

Are the commit messages enough? If not, elaborate.

@ilija-lazoroski ilija-lazoroski changed the title ui: Remove "Congrats" message and change header Ransomware quickstart - Remove "Congrats" message and change header Jul 12, 2021
@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #1314 (a5151a6) into develop (af739b6) will increase coverage by 0.22%.
The diff coverage is n/a.

❗ Current head a5151a6 differs from pull request most recent head bf5ff8d. Consider uploading reports for the commit bf5ff8d to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1314      +/-   ##
===========================================
+ Coverage    30.87%   31.10%   +0.22%     
===========================================
  Files          454      458       +4     
  Lines        13545    13596      +51     
===========================================
+ Hits          4182     4229      +47     
- Misses        9363     9367       +4     
Impacted Files Coverage Δ
...ey/monkey_island/cc/resources/ransomware_report.py 0.00% <0.00%> (ø)
...sts/mongo_documents/telemetries/file_encryption.py 100.00% <0.00%> (ø)
...island/cc/services/ransomware/ransomware_report.py 100.00% <0.00%> (ø)
...ey/tests/data_for_tests/mongo_documents/monkeys.py 100.00% <0.00%> (ø)
...nkey/tests/data_for_tests/mongo_documents/edges.py 100.00% <0.00%> (ø)
.../infection_monkey/ransomware/ransomware_payload.py 96.66% <0.00%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af739b6...bf5ff8d. Read the comment docs.

Copy link
Contributor

@VakarisZ VakarisZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the bottom margin of the title and change "Get Started" to "Getting Started". Also, add 20px of space between buttons and next section in the page

@ilija-lazoroski
Copy link
Contributor Author

image

@ilija-lazoroski ilija-lazoroski force-pushed the 1241/ransomware-quickstart-remove-congrats branch from 09731f6 to a5151a6 Compare July 13, 2021 13:23
@mssalvatore mssalvatore merged commit 3c84e70 into develop Jul 13, 2021
@mssalvatore mssalvatore deleted the 1241/ransomware-quickstart-remove-congrats branch July 13, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants