Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate credentials in system info telem #1493

Merged
merged 2 commits into from
Sep 28, 2021

Conversation

VakarisZ
Copy link
Contributor

@VakarisZ VakarisZ commented Sep 27, 2021

What does this PR do?

Removes the unnecessary "mimikatz" info from telemetry data since the exact same data is stored under "credentials" key

Couldn't find any usages or reason for duplicating credentials into "mimikatz" key

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by building monkey, gathering credentials, testing the report

  • If applicable, add screenshots or log transcripts of the feature working

@codecov
Copy link

codecov bot commented Sep 27, 2021

Codecov Report

Merging #1493 (d240427) into develop (e40c83c) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1493      +/-   ##
===========================================
- Coverage    42.26%   42.25%   -0.02%     
===========================================
  Files          475      475              
  Lines        14114    14113       -1     
===========================================
- Hits          5965     5963       -2     
- Misses        8149     8150       +1     
Impacted Files Coverage Δ
...ction_monkey/system_info/windows_info_collector.py 0.00% <ø> (ø)
...nkey_island/cc/models/telemetries/telemetry_dal.py 91.30% <100.00%> (-8.70%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e40c83c...d240427. Read the comment docs.

@VakarisZ VakarisZ merged commit beafc0b into develop Sep 28, 2021
@VakarisZ VakarisZ deleted the credential_duplication_fix branch September 28, 2021 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants