-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1888 rename monkey endpoint #1893
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1893 +/- ##
===========================================
+ Coverage 54.89% 54.98% +0.09%
===========================================
Files 447 447
Lines 12655 12683 +28
===========================================
+ Hits 6947 6974 +27
- Misses 5708 5709 +1
Continue to review full report at Codecov.
|
* Remove 32-bitness * Fix api/agent/download endpoint
e6e4583
to
743efe3
Compare
+ r":5000/api/agent/download/linux " | ||
+ r"-O monkey-linux-" | ||
+ bit_text | ||
+ r"; chmod +x monkey-linux-" | ||
+ bit_text |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need bit_text here anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so. I have assumed that this is not the task to remove that..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's removed in the windows function in this file. Might as well remove it here too.
What does this PR do?
Fixes #1888 .
Renames
api/monkey
toapi/agent
PR Checklist
Testing Checklist
Explain Changes
Are the commit messages enough? If not, elaborate.