-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Island: Change schema compiler to merge plugins and exploiters #2803
Island: Change schema compiler to merge plugins and exploiters #2803
Conversation
monkey/monkey_island/cc/repositories/utils/hard_coded_exploiters.py
Outdated
Show resolved
Hide resolved
6c90ff0
to
ac9cc22
Compare
"info": "Exploits a privilege escalation vulnerability (CVE-2020-1472) in a Windows " | ||
"server domain controller (DC) by using the Netlogon Remote Protocol (MS-NRPC). " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the wrong description, will fix in later PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but I think we can improve a few names.
|
||
# Exploiters that are not plugins need to be added manually. This should be removed | ||
# once all exploiters are turned into plugins | ||
def _add_exploiters(self, schema: Dict[str, Any]) -> Dict[str, Any]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def _add_exploiters(self, schema: Dict[str, Any]) -> Dict[str, Any]: | |
def _add_non_plugin_exploiters(self, schema: Dict[str, Any]) -> Dict[str, Any]: |
@staticmethod | ||
def _get_plugin_type_string(plugin_type: AgentPluginType): | ||
return plugin_type.name.lower() | ||
def _add_properties_to_objects(self, schema: Dict[str, Any]) -> Dict[str, Any]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def _add_properties_to_objects(self, schema: Dict[str, Any]) -> Dict[str, Any]: | |
def _add_properties_field_to_plugin_types(self, schema: Dict[str, Any]) -> Dict[str, Any]: |
^^ Not sure about this name, but something more descriptive would be good.
Exploiter plugins and hard-coded plugins must be merged to create a cohesive configuration schema
ea818d9
to
3fd64f9
Compare
f6c0a59
to
65deffc
Compare
What does this PR do?
Exploiter plugins and hard-coded plugins must be merged to create a cohesive configuration schema
Fixes part of #2785
PR Checklist
Testing Checklist