Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Change Guardicore logo with Akamai logo #2913

Merged
merged 3 commits into from
Feb 2, 2023

Conversation

ilija-lazoroski
Copy link
Contributor

@ilija-lazoroski ilija-lazoroski commented Feb 2, 2023

What does this PR do?

Add any further explanations here.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by running the Island and checking the links

  • If applicable, add screenshots or log transcripts of the feature working

image
image

Copy link
Collaborator

@mssalvatore mssalvatore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase on develop and add a changelog entry.

@ilija-lazoroski ilija-lazoroski force-pushed the change-guardicore-logo-with-akamai-logo branch from adc414b to 8524c2c Compare February 2, 2023 12:45
@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Base: 66.34% // Head: 66.34% // No change to project coverage 👍

Coverage data is based on head (277071d) compared to base (6e209f2).
Patch has no changes to coverable lines.

❗ Current head 277071d differs from pull request most recent head 471c24e. Consider uploading reports for the commit 471c24e to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2913   +/-   ##
========================================
  Coverage    66.34%   66.34%           
========================================
  Files          424      424           
  Lines        12269    12269           
========================================
  Hits          8140     8140           
  Misses        4129     4129           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mssalvatore mssalvatore merged commit a82b5ef into develop Feb 2, 2023
@mssalvatore mssalvatore deleted the change-guardicore-logo-with-akamai-logo branch February 2, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants