-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2950 custom sensitive text area widget #2973
Conversation
Codecov ReportBase: 66.45% // Head: 66.45% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## develop #2973 +/- ##
========================================
Coverage 66.45% 66.45%
========================================
Files 424 424
Lines 12312 12312
========================================
Hits 8182 8182
Misses 4130 4130 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not add more class components. Refactor monkey/monkey_island/cc/ui/src/components/ui-components/SensitiveTextareaInput.js to hooks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting solution -- I wonder how other password fields are implemented
monkey/monkey_island/cc/ui/src/components/ui-components/SensitiveTextareaInput.js
Outdated
Show resolved
Hide resolved
c9f1a5c
to
58ed063
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way we can reduce code duplication between the two SensitiveText components?
We can't name it "Key Pair 1", "Key Pair 2", ...? |
I didn't found any way to do it like that. Do we want to spend some time? |
Nah. It's fine. |
58ed063
to
361d191
Compare
The main benefit is that we reduce the duplication in styling and icons
What does this PR do?
Fixes #2950.
Things left to do:
PR Checklist
Testing Checklist