Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2950 custom sensitive text area widget #2973

Merged
merged 8 commits into from
Feb 15, 2023

Conversation

ilija-lazoroski
Copy link
Contributor

@ilija-lazoroski ilija-lazoroski commented Feb 14, 2023

What does this PR do?

Fixes #2950.
Things left to do:

  • Test it with actual SHHKeypair

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by exploiting sshkey-12 with only sshkey pair

  • If applicable, add screenshots or log transcripts of the feature working

image

image

image

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Base: 66.45% // Head: 66.45% // No change to project coverage 👍

Coverage data is based on head (9174a0e) compared to base (34c25ab).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2973   +/-   ##
========================================
  Coverage    66.45%   66.45%           
========================================
  Files          424      424           
  Lines        12312    12312           
========================================
  Hits          8182     8182           
  Misses        4130     4130           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ilija-lazoroski ilija-lazoroski marked this pull request as ready for review February 14, 2023 16:02
Copy link
Contributor

@VakarisZ VakarisZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not add more class components. Refactor monkey/monkey_island/cc/ui/src/components/ui-components/SensitiveTextareaInput.js to hooks

Copy link
Contributor

@cakekoa cakekoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting solution -- I wonder how other password fields are implemented

@mssalvatore
Copy link
Collaborator

Can we name this better?

image

CHANGELOG.md Outdated Show resolved Hide resolved
@ilija-lazoroski
Copy link
Contributor Author

Can we name this better?

image

We can name it the same for every item there...

image

@ilija-lazoroski ilija-lazoroski force-pushed the 2950-custom-sensitive-text-area-widget branch from c9f1a5c to 58ed063 Compare February 14, 2023 17:07
Copy link
Contributor

@cakekoa cakekoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way we can reduce code duplication between the two SensitiveText components?

@mssalvatore
Copy link
Collaborator

mssalvatore commented Feb 14, 2023

@ilija-lazoroski

We can name it the same for every item there...

We can't name it "Key Pair 1", "Key Pair 2", ...?

@ilija-lazoroski
Copy link
Contributor Author

@ilija-lazoroski

We can name it the same for every item there...

We can't name it "Key Pair 1", "Key Pair 2", ...?

I didn't found any way to do it like that. Do we want to spend some time?

@mssalvatore
Copy link
Collaborator

Do we want to spend some time?

Nah. It's fine.

@mssalvatore mssalvatore force-pushed the 2950-custom-sensitive-text-area-widget branch from 58ed063 to 361d191 Compare February 14, 2023 19:01
The main benefit is that we reduce the duplication in styling and icons
@mssalvatore mssalvatore merged commit 97b6a62 into develop Feb 15, 2023
@mssalvatore mssalvatore deleted the 2950-custom-sensitive-text-area-widget branch February 15, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write a custom component for SSHKeypair objects in UI
5 participants