Update manual run page #3328
Merged
Update manual run page #3328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilija-lazoroski
requested changes
May 10, 2023
+1 These changes are good. The clarification is needed. But we want to have all Island IPs in the agent command's server list. |
|
|
ilija-lazoroski
approved these changes
May 10, 2023
mssalvatore
reviewed
May 10, 2023
CHANGELOG.md
Outdated
| @@ -19,6 +19,7 @@ Changelog](https://keepachangelog.com/en/1.0.0/). | |||
| - Hard-coded Mimikatz credentials collector to a plugin. #3168 | |||
| - Hard-coded Zerologon exploiter to a plugin. #3164 | |||
| - Hard-coded SSH credentials collector to a plugin. #3169 | |||
| - Manual run page UI. #3328 | |||
There was a problem hiding this comment.
Use the issue number, not the PR number.
mssalvatore
force-pushed
the
2593-update-manual-run-page
branch
from
b00fa48
to
ec60c40
Compare
mssalvatore
added a commit
that referenced
this pull request
Mar 29, 2024
We ran into a problem with #2593 where it was improperly resolved. PR #3328 did not fully resolve the issue, but was merged because it made necessary improvements. However, because the PR template contained "Fixes #...", when PR #3328 was merged GitHub automatically closed Issue #2593. This flew under the radar and Issue #2593 was therefore not properly resolved until 2 releases later. By changing this template, we hope to avoid similar sequences of events in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2593
PR Checklist
Was the documentation framework updated to reflect the changes?Testing Checklist
Added relevant unit tests?Do all unit tests pass?Do all end-to-end tests pass?