Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log4Shell: Add options #3435

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Log4Shell: Add options #3435

merged 1 commit into from
Jun 22, 2023

Conversation

cakekoa
Copy link
Contributor

@cakekoa cakekoa commented Jun 22, 2023

What does this PR do?

Fixes part of #3388.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Do all unit tests pass?
  • Do all end-to-end tests pass?
  • Any other testing performed?

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

Comment on lines 29 to 30
"The maximum time (in seconds) to wait for a successfully exploited Log4Shell server "
"to download the agent binary."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's not really a "log4shell server".

Suggested change
"The maximum time (in seconds) to wait for a successfully exploited Log4Shell server "
"to download the agent binary."
"The maximum time (in seconds) to wait for a successfully exploited server to "
"download the agent binary."

@cakekoa cakekoa merged commit 7381f39 into develop Jun 22, 2023
@cakekoa cakekoa deleted the 3388-options branch June 22, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants