Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3392 gzip plugins #3447

Merged
merged 20 commits into from
Jun 29, 2023
Merged

3392 gzip plugins #3447

merged 20 commits into from
Jun 29, 2023

Conversation

ilija-lazoroski
Copy link
Contributor

What does this PR do?

Fixes #3392 .

Add any further explanations here.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Do all unit tests pass?
  • Do all end-to-end tests pass?
  • Any other testing performed?

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

Copy link
Collaborator

@mssalvatore mssalvatore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the agent changes got dropped. The Island should be recompressing source archives before sending them to the agent to save network traffic and to keep the AgentPlugin types consistent.

Copy link
Collaborator

@mssalvatore mssalvatore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Waiting on MSI tests.

@mssalvatore mssalvatore merged commit 799c392 into develop Jun 29, 2023
@mssalvatore mssalvatore deleted the 3392-gzip-plugins branch June 29, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gzip plugins' source.tar
2 participants