3418 available plugins #3620
3418 available plugins #3620
Conversation
| * makeAvailablePluginsIterator() { | ||
| for (const plugin_type in this.availablePlugins) { | ||
| for (const plugin_name in this.availablePlugins[plugin_type]) { | ||
| if (!this.pluginInstalled(plugin_type, plugin_name)) { | ||
| // There may be multiple versions of the same plugin, so we only want the latest one | ||
| yield this.availablePlugins[plugin_type][plugin_name].slice(-1)[0]; | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| [Symbol.iterator]() { | ||
| return this.makeAvailablePluginsIterator(); | ||
| } |
There was a problem hiding this comment.
This is object-oriented approach in an otherwise functional code. We can transform the data if we need a list, but creating our own collection that's sometimes object sometimes list complicates usage
|
Don't push directly into |
VakarisZ
changed the base branch from
3418-plugins-page
to
3418-plugin-installation-screen
|
|
||
| return ( | ||
| <Box> | ||
| <Row className='grid-tools'> |
There was a problem hiding this comment.
Don't use Bootstrap's col/row/button, but use the MUI ones.
Using flex properties on the tools wrapper might do the job.
In case you need a custom stylesheet- I would suggest creating a new module for it.
| @@ -0,0 +1,53 @@ | |||
| import React, {useEffect, useState} from 'react'; | |||
There was a problem hiding this comment.
There's a PR for that component.
Make sure not to override it before merging.
| refreshAvailablePlugins(); | ||
| }, []); | ||
|
|
||
| useEffect(() => { |
There was a problem hiding this comment.
Why not do it in the first useEffect?
| ] | ||
| } | ||
|
|
||
| const pluginName = row.name; |
There was a problem hiding this comment.
move these declarations to the top of the function.
|
This was merged, I don't know why github doesn't pick it the merge commit |
What does this PR do?
Fixes part of #3418.
Populates the Available Plugins table, and allows plugins to be installed.
PR Checklist
Testing Checklist