Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Add custom Toggle component #3626

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

ordabach
Copy link
Contributor

What does this PR do?

Fixes part of #3418

  • Add custom Toggle component

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Do all unit tests pass?
  • Do all end-to-end tests pass?
  • Any other testing performed?

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

ordabach added a commit that referenced this pull request Aug 28, 2023
@ordabach ordabach force-pushed the 3418-toggle-component branch from 47e50f7 to fd26455 Compare August 28, 2023 22:58
ordabach added a commit that referenced this pull request Aug 28, 2023
@ordabach ordabach force-pushed the 3418-toggle-component branch from b32a076 to 0e83c0b Compare August 28, 2023 23:03
}
}

if (options?.length === 0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like this won't return null if options is not defined. Is this correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@ordabach ordabach force-pushed the 3418-toggle-component branch from 0e83c0b to fcca654 Compare August 29, 2023 17:33
@ordabach ordabach merged commit e348abf into 3418-plugin-installation-screen Aug 29, 2023
@cakekoa cakekoa deleted the 3418-toggle-component branch August 30, 2023 17:45
VakarisZ pushed a commit that referenced this pull request Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants