3418 search displayed fields #3646
Conversation
ordabach
changed the base branch from
develop
to
3418-plugin-installation-screen
Note: This does not search the "author" field, since it is not part of the plugin.
VakarisZ
force-pushed
the
3418-search-displayed-fields
branch
from
ab19693
to
a5b3b79
Compare
There was a problem hiding this comment.
I was actually wondering if we could use the built-in filtering on the data grid component. However, it looks like that may be limited to only filtering on a single column at a time (in the free version), which wouldn't work for us.
We were already using a mix of row and backend data so switching to just operating on the row data makes sense as far as consistency is concerned.
|
|
||
| const onRefreshCallback = () => { | ||
| setSuccessfullyInstalledPluginsIds([]); | ||
| setInstallingAllSafePlugins(unSafeDispalyedPlugins.length > 0 && safeDispalyedPlugins.length === 0 || displayedRows.length === 0) |
There was a problem hiding this comment.
Noticed this typo: unSafeDispalyedPlugins -> unSafeDisplayedPlugins
There was a problem hiding this comment.
There's a todo to refactor this method, I already have the changes, but out of scope
|
|
||
| export const getPluginsTableRows = (pluginsList :AgentPlugin[]) => { | ||
| export const getDefaultPluginsTableRows = (pluginsList: AgentPlugin[]) :PluginRow[] => { |
There was a problem hiding this comment.
What is the meaning of default here? Based on the name it sounds like it would output a default set of rows, instead of generating rows from the data with the default set of columns. Maybe 'defaultGetPluginsTableRows makes more sense?
What does this PR do?
Fixes #3418.
Add any further explanations here.
PR Checklist
Testing Checklist