Added request timeouts #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acepace
reviewed
Nov 13, 2020
| @@ -9,6 +9,9 @@ | |||
|
|
|||
| import infection_monkey.monkeyfs as monkeyfs | |||
| import infection_monkey.tunnel as tunnel | |||
| from common.common_consts.timeouts import (LONG_REQUEST_TIMEOUT, | |||
There was a problem hiding this comment.
I think this is default isort style
acepace
reviewed
Nov 13, 2020
Comment on lines
5
to
11
| import logging | ||
| import subprocess | ||
|
|
||
| import nmb.NetBIOS | ||
| from impacket.dcerpc.v5 import epm, nrpc, transport | ||
|
|
||
| import infection_monkey.config | ||
| from infection_monkey.network.HostFinger import HostFinger | ||
| from infection_monkey.utils.environment import is_windows_os | ||
|
|
There was a problem hiding this comment.
Why is this part of the same commit/PR?
There was a problem hiding this comment.
Making new PR's for small cleanups like this would be annoying. It's on a separate, descriptive commit though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes requests not having timeouts, which causes a delay in monkey executions or make it hang.
Also removed unused imports in one of the fingerprinters
Add any further explanations here.
PR Checklist
Testing Checklist