Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better content loading API (and docs) #212

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Better content loading API (and docs) #212

wants to merge 4 commits into from

Conversation

gudzpoz
Copy link
Owner

@gudzpoz gudzpoz commented Oct 6, 2024

This PR adds a few API to facilitate content loading:

Buffers:

  • ByteBuffer conversions via Lua::push
  • Lua strings will be converted to ByteBuffer if Java typing requires so.
  • One can now turn LuaValues into buffers (or vice versa).

Documentation:

  • Javadoc for Lua::load is furnished, hopefully preventing misusages.

luaL_dofile equivalence:

  • Add Lua::require.
  • Encourage using Lua::require instead of relying on a filesystem.

Hopefully closes #207, #209 and #210

@gudzpoz gudzpoz changed the title feat: add conversions between lua strings and java buffers Better content loading API (and docs) Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gudzpoz