Toplevel.EnsureVisibleBounds throws an exception if border is null. #2267

BDisp · 2023-01-03T13:14:17Z

This unit test proves that:

public void EnsureVisibleBounds_With_Border_Null_Not_Throws ()
{
	var top = new Toplevel ();
	Application.Begin (top);

	var exception = Record.Exception (() => ((FakeDriver)Application.Driver).SetBufferSize (0, 10));
	Assert.Null (exception);

	exception = Record.Exception (() => ((FakeDriver)Application.Driver).SetBufferSize (10, 0));
	Assert.Null (exception);
}

Here a print screen of the error if the console height is resized to zero:

…f border is null.

Fixes #2267. Toplevel.EnsureVisibleBounds throws an exception if border is null.

…f border is null.

@BDisp

* Changed ansi esc sequence used on exit. * Changed ansi esc sequence used on exit. * Improves HeightAsBuffer although currently only works on Windows. * Fixes #2267. Toplevel.EnsureVisibleBounds throws an exception if border is null. * Changing comment as requested. * Fixes indentation. * Seems not needed for now, maybe some update, comment for now. * Renamed HeightAsBuffer to EnableConsoleScrolling and made it obsolete. * Add comment on remarks for EnableConsoleScrolling. * merged @BDisp's EnableConsoleScrolling PR * Fixes buffer for Windows Terminal. * Fixes issue in Windows Terminal on resizing causing some lines not be drawing after exceptions. * merge #9 * merged #9 * use ESC [ ? 1047 * Tweaks with new esc codes * Fixed curses driver to not nuke scroll buffer and to resize properly * merge * Cleand up netdriver escape codes * fixed spaces->tabs * fixed spaces->tabs * fixed spaces->tabs * fixed spaces->tabs * fixed merge issue and spaces->tabs * fixed spaces->tabs * fixed spaces->tabs * fixed spaces->tabs * fixed build error * removed old comments * Resolving merge conflicts. * Ensuring reset the EnableConsoleScrolling. * Changing from HeightAsBuffer to EnableConsoleScrolling. * Done requested changes. * Reformatting. * Rename to EscSeqReqStatus. * Removing Console.Out.Flush (); --------- Co-authored-by: Charlie Kindel <tig@users.noreply.github.com> Co-authored-by: Tig Kindel <tig@kindel.com>

@BDisp

…2375) * Changed ansi esc sequence used on exit. * Changed ansi esc sequence used on exit. * Improves HeightAsBuffer although currently only works on Windows. * Fixes gui-cs#2267. Toplevel.EnsureVisibleBounds throws an exception if border is null. * Changing comment as requested. * Fixes indentation. * Seems not needed for now, maybe some update, comment for now. * Renamed HeightAsBuffer to EnableConsoleScrolling and made it obsolete. * Add comment on remarks for EnableConsoleScrolling. * merged @BDisp's EnableConsoleScrolling PR * Fixes buffer for Windows Terminal. * Fixes issue in Windows Terminal on resizing causing some lines not be drawing after exceptions. * merge #9 * merged #9 * use ESC [ ? 1047 * Tweaks with new esc codes * Fixed curses driver to not nuke scroll buffer and to resize properly * merge * Cleand up netdriver escape codes * fixed spaces->tabs * fixed spaces->tabs * fixed spaces->tabs * fixed spaces->tabs * fixed merge issue and spaces->tabs * fixed spaces->tabs * fixed spaces->tabs * fixed spaces->tabs * fixed build error * removed old comments * Resolving merge conflicts. * Ensuring reset the EnableConsoleScrolling. * Changing from HeightAsBuffer to EnableConsoleScrolling. * Done requested changes. * Reformatting. * Rename to EscSeqReqStatus. * Removing Console.Out.Flush (); --------- Co-authored-by: Charlie Kindel <tig@users.noreply.github.com> Co-authored-by: Tig Kindel <tig@kindel.com>

BDisp added a commit to BDisp/Terminal.Gui that referenced this issue Jan 3, 2023

Fixes gui-cs#2267. Toplevel.EnsureVisibleBounds throws an exception i…

03e0f08

…f border is null.

This was referenced Jan 3, 2023

Fixes #2267. Toplevel.EnsureVisibleBounds throws an exception if border is null. #2268

Merged

Fixes #2249. CharacterMap isn't refreshing well non-BMP code points on scroll. #2250

Closed

tig added the bug label Jan 3, 2023

tig closed this as completed in #2268 Jan 13, 2023

tig added a commit that referenced this issue Jan 13, 2023

Merge pull request #2268 from BDisp/ensurevisiblebounds-fix-2267

264f0b0

Fixes #2267. Toplevel.EnsureVisibleBounds throws an exception if border is null.

BDisp added a commit to BDisp/Terminal.Gui that referenced this issue Jan 18, 2023

Fixes gui-cs#2267. Toplevel.EnsureVisibleBounds throws an exception i…

1aab780

…f border is null.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Toplevel.EnsureVisibleBounds throws an exception if border is null. #2267

Toplevel.EnsureVisibleBounds throws an exception if border is null. #2267

BDisp commented Jan 3, 2023 •

edited

Loading

Toplevel.EnsureVisibleBounds throws an exception if border is null. #2267

Toplevel.EnsureVisibleBounds throws an exception if border is null. #2267

Comments

BDisp commented Jan 3, 2023 • edited Loading

BDisp commented Jan 3, 2023 •

edited

Loading