Fixes #1446. Added more features to the Border and Toplevel focus. #1447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before: After the fix: |
tig
approved these changes
Sep 29, 2021
* added null guard to fix null ref when pressing keyDown inside combobox Improved an error message when view cannot be found * Added a unit test to ensure combobox can process all key events Found and fixed a new nullref * Found a new bug when source is already present and combobox is added to a top view * searchSet is auto initialized to new List() now to make the code a little bit safer
Bumps [ReportGenerator](https://github.com/danielpalme/ReportGenerator) from 4.8.12 to 4.8.13. - [Release notes](https://github.com/danielpalme/ReportGenerator/releases) - [Commits](danielpalme/ReportGenerator@v4.8.12...v4.8.13) --- updated-dependencies: - dependency-name: ReportGenerator dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…1448) * Fixes gui-cs#1445. Fixing more the Curses and WSL clipboard. * Fixing unit tests. * Changing namespace. * Fixes WSL2 clipboard unit test. * Upgrades devcontainer with the MainLoop fix. * Fixes pasting with no selection and with lines break. * Prevents the event button click being fired after a button pressed with mouse move. * Fixes the char [ not being processed.
…cation key. (gui-cs#1450) * Added Application.QuitKey property to allow change the quitting application key. * Fixes QuitKey unit test by reseting his value. * Locks timeouts until is added.
BDisp
added a commit
to BDisp/Terminal.Gui
that referenced
this pull request
Oct 5, 2021
…us. (gui-cs#1447) * Fixes gui-cs#1446. Added more features to the Border and Toplevel focus. * Prevents throwing exception on negative effect3DOffset values * Ensures that a view can be focused. * Only sets focus if it isn't disposing. * Fixes ViewToScreen and DrawChildBorder Effect3D. * Unit test for negative coordinates with the ViewToScreen method. * Added Tab navigation feature to the Editor scenario. * ComboBox cursonDownKey nullref fix (gui-cs#1472) * added null guard to fix null ref when pressing keyDown inside combobox Improved an error message when view cannot be found * Added a unit test to ensure combobox can process all key events Found and fixed a new nullref * Found a new bug when source is already present and combobox is added to a top view * searchSet is auto initialized to new List() now to make the code a little bit safer * Fixes WindowsDriver HeightAsBuffer set to false. (gui-cs#1466) * Bump ReportGenerator from 4.8.12 to 4.8.13 (gui-cs#1473) Bumps [ReportGenerator](https://github.com/danielpalme/ReportGenerator) from 4.8.12 to 4.8.13. - [Release notes](https://github.com/danielpalme/ReportGenerator/releases) - [Commits](danielpalme/ReportGenerator@v4.8.12...v4.8.13) --- updated-dependencies: - dependency-name: ReportGenerator dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fixes gui-cs#1445. Fixing more the Curses and WSL clipboard. (gui-cs#1448) * Fixes gui-cs#1445. Fixing more the Curses and WSL clipboard. * Fixing unit tests. * Changing namespace. * Fixes WSL2 clipboard unit test. * Upgrades devcontainer with the MainLoop fix. * Fixes pasting with no selection and with lines break. * Prevents the event button click being fired after a button pressed with mouse move. * Fixes the char [ not being processed. * Added Application.QuitKey property to allow change the quitting application key. (gui-cs#1450) * Added Application.QuitKey property to allow change the quitting application key. * Fixes QuitKey unit test by reseting his value. * Locks timeouts until is added. * Fixes gui-cs#1467. AlternateForward/BackwardKey bypasses dialog modality (gui-cs#1468) * Changed namespace. * Fixing merge conflicts. * Fixes mouse click issue. * Removing windows resizing because buffer resizing is enough. * Fixes gui-cs#1477. Mouse click and console bottom on Windows Terminal. Co-authored-by: Igor Bagdamyan <37334640+En3Tho@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done @tig, I hope you like it. #1436 (review)