Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2451. ListView SelectedItem should be -1 by default. #2452

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Mar 27, 2023

Fixes #2451 - The ComboBoxTests fix was only to pass the tests because it will be changed later in a WIP at the moment.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@tig tig merged commit f518ddf into gui-cs:v2_develop Mar 27, 2023
@BDisp BDisp deleted the v2_listview-selecteditem-fix_2451 branch March 27, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants