-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #2663 - No more nested classes #2664
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please back out the changes to the ConsoleDrivers and related code. I will take care of this in #2612; it's diverged enough that merging from this PR will be a PITA. Thanks.
I've reverted everything in the I have commented out You can still suppress in source: #pragma warning disable CA1034 // Nested types should not be visible
[...]
#pragma warning restore CA1034 // Nested types should not be visible
|
- LineCanvasCell back to just Cell - ApplicationRunState back to just RunState
…i.cs into no-more-nested-classes
Fixes #2663 - Promote all nested classes to full classes
In #2406 many classes were moved from nested to root level. This PR explores moving all classes (except those in SpinnerStyle.cs) out to their own classes.
In some cases e.g.
Curses.Window
I named the new classCursesWindow
which is I think a nice way of grouping things together. See also e.g.Bar
(previouslyBarSeries.Bar
) is nowBarSeriesBar
Pull Request checklist:
CTRL-K-D
to automatically reformat your files before committing.dotnet test
before commit///
style comments)