Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Disposal Test and fix an issue where the CopyClipboard test was failing #2936

Merged
merged 4 commits into from
Oct 30, 2023

Conversation

a-usr
Copy link

@a-usr a-usr commented Oct 26, 2023

Fixes #???? - Include a terse summary of the change or which issue is fixed.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@a-usr a-usr requested a review from tig as a code owner October 26, 2023 15:02
@a-usr
Copy link
Author

a-usr commented Oct 30, 2023

please?

Copy link
Collaborator

@tig tig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely! I'll merge as soon as you address my comments.

UnitTests/Views/ViewDisposalTest.cs Show resolved Hide resolved
UnitTests/Views/ViewDisposalTest.cs Show resolved Hide resolved
UnitTests/Views/ViewDisposalTest.cs Outdated Show resolved Hide resolved
UnitTests/Views/ViewDisposalTest.cs Show resolved Hide resolved
@tig tig merged commit 34c6b6e into gui-cs:develop Oct 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants