Fixes #3366 - Add ability to disable AutoSize

[tznind]

Fixes

• Fixes Must set AutoSize to false before setting Width #3366

Proposed Changes/Todos

Adds a static variable that allows disableing AutoSize.

Disables AutoSize instead of throwing Exception when setting Width/Height on a View

Currently the designer emits code as follows:

 this.lblLoading = new Terminal.Gui.Label();
 this.lblLoading.Data = "lblLoading";
 this.lblLoading.Text = "Please wait ...";
 this.lblLoading.Width = 36;
 this.lblLoading.Height = 1;
 this.lblLoading.X = 1;
 this.lblLoading.Y = 1;
 this.lblLoading.TextAlignment = TextAlignment.Left;
 this.Add(this.lblLoading);

I looked into adding AutoSize = false on every single view generated and every piece of code emitted. That kinda worked but was ugly. Then I realized I had to update all my existing .Designer.cs files code with this AutoSize=false too.

I think this is a better solution, the ability to disable autosize across the board.

This can be removed once AutoSize itself is removed.

Pull Request checklist:

• I've named my PR in the form of "Fixes #issue. Terse description."
• My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
• My code follows the Terminal.Gui library design guidelines
• I ran dotnet test before commit
• I have made corresponding changes to the API documentation (using /// style comments)
• My changes generate no new warnings
• I have checked my code and corrected any poor grammar or misspellings
• I conducted basic QA to assure all features are working

[tig]

Love.

I'll look deeper later today.

[tig]

I have a better idea. Now that the exception I put in has weeded out all/most code that is incorrect, we can remove it and instead just change AutoSize to false:

    public Dim Width
    {
        get => VerifyIsInitialized (_width, nameof (Width));
        set
        {
            if (Equals (_width, value))
            {
                return;
            }

            _width = value ?? throw new ArgumentNullException (nameof (value), @$"{nameof (Width)} cannot be null");

            if (AutoSize)
            {
                Debug.WriteLine (@$"Must set AutoSize to false before setting {nameof (Width)}.");
                AutoSize = false;
            }

            bool isValidNewAutoSize = AutoSize && IsValidAutoSizeWidth (_width);

            if (IsAdded && AutoSize && !isValidNewAutoSize)
            {
                Debug.WriteLine (@$"Must set AutoSize to false before setting {nameof (Width)}.");
                AutoSize = false;
            }

            OnResizeNeeded ();
        }
    }

If I do this, all unit tests pass and I see no functional issues in some light tests...

[tznind]

we can remove it and instead just change AutoSize to false

Works for me! Although when I remove the lines (in Button etc) setting AutoSize = true I do get unit test failures.

[tznind]

Ah I see how you mean. Replace the exception with AutoSize = false; Yeah that would work nicely.

[tznind]

@tig I have changed this PR to do as you suggest (Set AutoSize=false instead of throw Exception).

Please let me know if I have misunderstood.