Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add View.LayoutComplete event #587

Closed
wants to merge 15 commits into from
Closed

Add View.LayoutComplete event #587

wants to merge 15 commits into from

Conversation

tig
Copy link
Collaborator

@tig tig commented May 31, 2020

See #569

@tig tig requested a review from migueldeicaza May 31, 2020 07:08
@migueldeicaza
Copy link
Collaborator

Love it!

@migueldeicaza
Copy link
Collaborator

This can go in as well - will defer on the conflicting file

@tig
Copy link
Collaborator Author

tig commented Jun 3, 2020

this will go in my mondo patch.

@tig tig closed this Jun 3, 2020
@tig tig mentioned this pull request Jun 3, 2020
migueldeicaza pushed a commit that referenced this pull request Jun 3, 2020
This PR includes:

#586 - Fixed Clipping
#587 - LayoutComplete
#591 - Sys Console Scenario
#590 - Significantly improves MessageBox, Dialog, Frame drawning and more
See the PRs above for all the details.

Here are the issues this closes:

Closes #299 - MessageBox now auto sizes
Closes #557 - MessageBoxes on small screens
Closes #432 - MessageBox does not deal with long text; width/height params are goofy
Closes #521 - MessageBox should take ustrings (BREAKING CHANGE)
Closes #35 - Dialog should have 1 char padding around edges
Closes #570 - Dialog should use computed layout for buttons
Closes #470 - UI Catalog: Add Dialogs Scenario
Closes #569 - LayoutComplete event
Plus probably more.
@tig tig deleted the OnLayoutComplete branch June 3, 2020 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants