Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements the mouse and keys of the MenuBar. #596

Merged
merged 7 commits into from
Jun 4, 2020

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Jun 2, 2020

The hot keys were been called to the wrong Toplevel even it isn't the current. Mouse changes was to get a better response. And there was fixed some minor bugs due the various previous interventions.

@BDisp
Copy link
Collaborator Author

BDisp commented Jun 2, 2020

I think this ce30a83 fixes #436.

@migueldeicaza
Copy link
Collaborator

We probably need a better description of what this change does on the description, it is hard to judge the changes without it.

@BDisp
Copy link
Collaborator Author

BDisp commented Jun 3, 2020

Without merge with 4a1f5a9 Alt key doesn't work in the Menu.

@tig
Copy link
Collaborator

tig commented Jun 3, 2020

@BDisp I'm very confused about what this PR does and doesn't do.

It makes a lot of changes that are hard to follow in the diff. Can you try to explain the problem and the fix more clearly?

@BDisp
Copy link
Collaborator Author

BDisp commented Jun 3, 2020

@BDisp I'm very confused about what this PR does and doesn't do.

It makes a lot of changes that are hard to follow in the diff. Can you try to explain the problem and the fix more clearly?

OnKeyUp and OnKeyDown in reality I reset them for what remains the same because my intention was to activate the Menu right after pressing and not when releasing the key but this is not effective because it activates right when switching between windows and leaves the Menu activated no need. At the mouse level, I activated both ButtonPressed and ButtonDoubleClicked to open and close the Menu more quickly. Now it works alternately, that is, if the Menu is closed both events will open and close it, otherwise. There is another commit that also solves a problem in which if you open the "Text Editor Demo" in the Example project, pressingCtrl + Qwould trigger the Application.Top Quit method that does not belong to the Toplevel current.

@BDisp
Copy link
Collaborator Author

BDisp commented Jun 3, 2020

@tig here is a video explaining what I was meaning about the Quit that belongs to the Application.Top is running in the Text Editor Demo. If I choose "Ok" to quit after I close the editor the application exits.

toplevel-keys

@tig tig merged commit 0756917 into gui-cs:master Jun 4, 2020
@tig
Copy link
Collaborator

tig commented Jun 4, 2020

You are awesome. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants