Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ShieldsIo class +semver: minor #189

Merged
merged 7 commits into from
Jul 22, 2024
Merged

Add ShieldsIo class +semver: minor #189

merged 7 commits into from
Jul 22, 2024

Conversation

guibranco
Copy link
Owner

Resolves #167

Before the change?

  • Add the ShieldsIo class.

After the change?

  • Add the ShieldsIo class.

Pull request checklist

  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been reviewed and added/updated if needed (for bug fixes/features)

Does this introduce a breaking change?

  • Yes
  • No

@guibranco guibranco linked an issue Jul 22, 2024 that may be closed by this pull request
[FEATURE] Add ShieldsIo class #167
Closed
@deepsource-autofix
style: format code with PHP CS Fixer
a36bdc2 
This commit fixes the style issues introduced in 7890b79 according to the output
from PHP CS Fixer.

Details: #189
@deepsource-io deepsource.io
Copy link

deepsource-io bot commented Jul 22, 2024 •
edited
Loading

Here's the code health analysis summary for commits e45a1a9..d64642d. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗
DeepSource SQL LogoSQL✅ SuccessView Check ↗
DeepSource Secrets LogoSecrets✅ SuccessView Check ↗
DeepSource PHP LogoPHP✅ SuccessView Check ↗
DeepSource Docker LogoDocker✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePhp
Branch Coverage100%100%
Composite Coverage95.7% (up 0.4% from main)95.7% (up 0.4% from main)
Line Coverage95.7% (up 0.4% from main)95.7% (up 0.4% from main)
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 22, 2024
View reviewed changes
docs/changelog.md
@@ -1,7 +1,10 @@
# Changelog

## Version 0.8 [2024-07-22]

Check warning

Code scanning / Markdownlint (reported by Codacy)

Expected: 1; Actual: 0; Below Warning documentation

Expected: 1; Actual: 0; Below
docs/changelog.md
## Version 0.7 [2024-07-04]
- [#145](https://github.com/guibranco/pancake/issues/145) - Add Color class by [@gvieiragoulart](https://github.com/gvieiragoulart)
- [#145](https://github.com/guibranco/pancake/issues/145) - Add Color class by [@gvieiragoulart](https://github.com/gvieiragoulart).

Check warning

Code scanning / Markdownlint (reported by Codacy)

Lists should be surrounded by blank lines Warning documentation

Lists should be surrounded by blank lines
docs/changelog.md
@@ -1,7 +1,10 @@
# Changelog

## Version 0.8 [2024-07-22]
- [#167](https://github.com/guibranco/pancake/issues/167) - Add ShieldsIo class by [@guibranco](https://github.com/guibranco).

Check warning

Code scanning / Markdownlint (reported by Codacy)

Lists should be surrounded by blank lines Warning documentation

Lists should be surrounded by blank lines
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 22, 2024
View reviewed changes
src/ShieldsIo.php
return $input;
}

public function generateBadgeUrl($label, $content, $color, $style, $labelColor, $logo)

Check notice

Code scanning / Phpmd (reported by Codacy)

This pattern reports methods with high cyclomatic complexity Note

The method generateBadgeUrl() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10.
src/ShieldsIo.php
return $input;
}

public function generateBadgeUrl($label, $content, $color, $style, $labelColor, $logo)

Check notice

Code scanning / Phpmd (reported by Codacy)

This pattern reports methods with a large number of possible paths Note

The method generateBadgeUrl() has an NPath complexity of 729. The configured NPath complexity threshold is 200.
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 22, 2024
View reviewed changes
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phpcs (reported by Codacy) found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@guibranco guibranco enabled auto-merge (squash) July 22, 2024 23:05
@gstraccini gstraccini bot added ☑️ auto-merge Auto-merge enabled by gstraccini-bot documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers hacktoberfest HACKTOBERFEST acceptable label help wanted Extra attention is needed labels Jul 22, 2024
guibranco and others added 5 commits July 23, 2024 00:06
@guibranco
Fix namespace
fe8d56f
@guibranco
Update composer
67e22c0
@guibranco
Fix optional parameters
2b4e497
@deepsource-autofix
style: format code with PHP CS Fixer
4874906 
This commit fixes the style issues introduced in 2b4e497 according to the output
from PHP CS Fixer.

Details: #189
@guibranco
Use http_build_query
d64642d
@codacy-production Codacy Production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
✅ +0.46% (target: -1.00%) ✅ 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (e45a1a9) 212 202 95.28%
Head commit (d64642d) 235 (+23) 225 (+23) 95.74% (+0.46%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#189) 23 23 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@github-actions GitHub Actions
Copy link
Contributor

Infisical secrets check: ✅ No secrets leaked!

Scan results:

11:17PM INF scanning for exposed secrets...
11:17PM INF 135 commits scanned.
11:17PM INF scan completed in 463ms
11:17PM INF no leaks found

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@guibranco guibranco merged commit 49d762c into main Jul 22, 2024
28 checks passed
@guibranco guibranco deleted the feature/167-feature-add-shieldsio-class branch July 22, 2024 23:18
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gstraccini GStraccini gstraccini approved these changes

Assignees

@guibranco guibranco

Labels
☑️ auto-merge Auto-merge enabled by gstraccini-bot documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers hacktoberfest HACKTOBERFEST acceptable label help wanted Extra attention is needed size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add ShieldsIo class
1 participant
@guibranco